Add NGINX configuration for UpstreamSettingsPolicy #2877
Merged
+1,398
−274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened as a draft so I can see changes more clearly, will mark as ready when I clean it up. |
bjee19
commented
Dec 10, 2024
kate-osborn
requested changes
Dec 10, 2024
sjberman
reviewed
Dec 10, 2024
kate-osborn
requested changes
Dec 11, 2024
internal/mode/static/nginx/config/policies/upstreamsettings/processor.go
Outdated
Show resolved
Hide resolved
sjberman
reviewed
Dec 11, 2024
sjberman
reviewed
Dec 11, 2024
kate-osborn
reviewed
Dec 11, 2024
sjberman
approved these changes
Dec 11, 2024
kate-osborn
requested changes
Dec 11, 2024
bjee19
merged commit eabc8c9
into
nginxinc:feature/upstream-settings-policy
37 checks passed
kate-osborn
pushed a commit
to kate-osborn/nginx-gateway-fabric
that referenced
this pull request
Dec 20, 2024
Translate data plane intermediary UpstreamSettingsPolicy configuration into NGINX configuration. Problem: I want the data plane configuration generated from my UpstreamSettingsPolicy to be translated into NGINX Configuration. Solution: Translate the data plane UpstreamSettingsPolicy configuration into NGINX configuration. Testing: Unit tests.
kate-osborn
pushed a commit
that referenced
this pull request
Dec 20, 2024
Translate data plane intermediary UpstreamSettingsPolicy configuration into NGINX configuration. Problem: I want the data plane configuration generated from my UpstreamSettingsPolicy to be translated into NGINX Configuration. Solution: Translate the data plane UpstreamSettingsPolicy configuration into NGINX configuration. Testing: Unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate data plane intermediary UpstreamSettingsPolicy configuration into NGINX configuration.
Problem: I want the data plane configuration generated from my UpstreamSettingsPolicy to be translated into NGINX Configuration.
Solution: Translate the data plane UpstreamSettingsPolicy configuration into NGINX configuration.
Testing: Unit tests.
Closes #2811
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.