Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: remove () typo from troubleshooting doc #2803

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

nginx-aoife
Copy link
Contributor

Problem & Proposed changes

An extra set of () in this relref is causing a broken link here https://docs.nginx.com/nginx-gateway-fabric/how-to/monitoring/troubleshooting/#broken-header-error.

image

Closes #ISSUE n/a

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@nginx-aoife nginx-aoife requested review from a team as code owners November 22, 2024 09:45
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (e05f4cf) to head (19fbabe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2803   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files         107      107           
  Lines       10997    10997           
  Branches       50       50           
=======================================
  Hits         9883     9883           
  Misses       1054     1054           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@nginx-aoife
Copy link
Contributor Author

If approved please Merge too.

@ADubhlaoich
Copy link
Contributor

Enabled automerge: I will take responsibility for creating a cherry pick to the release branch once this is merged.

@ADubhlaoich ADubhlaoich merged commit 222ecc0 into nginxinc:main Nov 22, 2024
42 checks passed
ADubhlaoich pushed a commit to ADubhlaoich/ngf-doc-work that referenced this pull request Nov 25, 2024
ADubhlaoich added a commit that referenced this pull request Nov 25, 2024
This commit cherry-picks changes from 3 recent documentation PRs from
main to the 1.5 release branch. More specifically, the work in the following PRs:

-  Update support referencing support package tool #2789
- Docs: remove () typo from troubleshooting doc #2803
- Clear up installation language #2808

---------

Co-authored-by: Madhu Rajagopal <[email protected]>
Co-authored-by: Saylor Berman <[email protected]>
Co-authored-by: nginx-aoife <[email protected]>
salonichf5 pushed a commit to salonichf5/nginx-gateway-fabric that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants