-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable data plane log level #2603
Conversation
Opening this and closing #2561 in order for the NGINX Plus image to be built correctly with the repo's certs. |
✅ Deploy Preview will be available once build job completes!
|
d34a1f8
to
226cc61
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2603 +/- ##
==========================================
+ Coverage 88.62% 88.66% +0.03%
==========================================
Files 105 106 +1
Lines 8116 8141 +25
Branches 50 50
==========================================
+ Hits 7193 7218 +25
Misses 866 866
Partials 57 57 ☔ View full report in Codecov by Sentry. |
Needed to squash and rebase so the commit trail is gone, no major changes to actual functionality or code since previous review. Only big changes has been adding the Helm schema to the chart's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but see my review for a couple of small suggestions. Nice work!
8d4f608
to
58e48b1
Compare
Add Nginx error log level to NginxProxy.
Problem: Users would like to assign a log level for the data plane.
Solution: Add Nginx error log level to NginxProxy which allows users to set the error log level for Nginx.
Testing: Unit tests and manual testing.
Manual testing included
ErrorLevel
field in the NginxProxy resource.main.conf
file and runningnginx -T
) in the nginx container was updated correctly. NGINX Debug logs work.info
log level.notice
such as theerror
level, after making changes which would result innotice
log levels being outputted (such as deleting and re-applying cafe.yaml in the cafe example), nonotice
log levels are outputted.nginx -T
correctly shows themain.conf
configuration file being included in the nginx configuration.ps aux |grep nginx
when inside the nginx container correctly showed nginx-debug processes.nginx.debug
), but the log level is not debug, NGF still works correctly. Also NGINX debug logs are not printed.Closes #901
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.