Replace TODO route condition with an Accepted/False condition #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2228 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 96 96
Lines 6715 6715
Branches 50 50
=======================================
Hits 5884 5884
Misses 774 774
Partials 57 57 ☔ View full report in Codecov by Sentry. |
sjberman
approved these changes
Jul 11, 2024
bjee19
approved these changes
Jul 11, 2024
kate-osborn
force-pushed
the
fix/todo-condition
branch
from
896d62d to
99ecaaa
Compare
Merged
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
…2228) Problem: When a route references a Gateway that is ignored, NGF adds the TODO condition: "The condition for this has not been implemented yet: Gateway is ignored. " This does not communicate to the user that the route is not accepted because the Gateway it references is ignored. Solution: Change this condition to be Accepted/False/GatewayIgnored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: When a route references a Gateway that is ignored, NGF adds the TODO condition:
The condition for this has not been implemented yet: Gateway is ignored. This does not communicate to the user that the route is not accepted because the Gateway it references is ignored.Solution: Change this condition to be Accepted/False/GatewayIgnored.
Testing: Verified that the condition is added to routes that reference an ignored Gateway.
Closes #2015
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.