Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes that reference an ignored Gateway are marked as Accepted #2015

Closed
kate-osborn opened this issue May 22, 2024 · 0 comments · Fixed by #2228
Closed

Routes that reference an ignored Gateway are marked as Accepted #2015

kate-osborn opened this issue May 22, 2024 · 0 comments · Fixed by #2228
Assignees
Labels
bug Something isn't working refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Milestone

Comments

@kate-osborn
Copy link
Contributor

Describe the bug
Routes that reference an ignored Gateway are marked as Accepted:

Name:         coffee
Namespace:    default
Labels:       <none>
Annotations:  <none>
API Version:  gateway.networking.k8s.io/v1
Kind:         HTTPRoute
Metadata:
  Creation Timestamp:  2024-05-21T21:42:21Z
  Generation:          2
  Resource Version:    3076364
  UID:                 beec9954-aadc-4023-acac-4e1c6643d5b4
Spec:
  Hostnames:
    cafe.example.com
  Parent Refs:
    Group:         gateway.networking.k8s.io
    Kind:          Gateway
    Name:          ignored-gateway
    Section Name:  http
  Rules:
    Backend Refs:
      Group:
      Kind:    Service
      Name:    coffee
      Port:    80
      Weight:  1
    Matches:
      Path:
        Type:   PathPrefix
        Value:  /coffee
Status:
  Parents:
    Conditions:
      Last Transition Time:  2024-05-21T21:44:17Z
      Message:               The route is accepted
      Observed Generation:   2
      Reason:                Accepted
      Status:                True
      Type:                  Accepted
      Last Transition Time:  2024-05-21T21:44:17Z
      Message:               spec.rules[0].backendRefs[0].name: Not found: "coffee"
      Observed Generation:   2
      Reason:                BackendNotFound
      Status:                False
      Type:                  ResolvedRefs
      Last Transition Time:  2024-05-21T21:44:17Z
      Message:               The condition for this has not been implemented yet: Gateway is ignored
      Observed Generation:   2
      Reason:                TODO
      Status:                True
      Type:                  TODO
    Controller Name:         gateway.nginx.org/nginx-gateway-controller
    Parent Ref:
      Group:         gateway.networking.k8s.io
      Kind:          Gateway
      Name:          ignored-gateway
      Namespace:     default
      Section Name:  http

To Reproduce
Steps to reproduce the behavior:

  1. Install NGF
  2. Create 2 Gateways
  3. Create an HTTP/GRPCRoute that references the ignored gateway
  4. Check the status of the route

Expected behavior
The parentRef that references the ignored Gateway should have the condition Accepted/False.

Your environment

  • Version of the NGINX Gateway Fabric - edge 5f9ec2d

Additional context

@mpstefan mpstefan added the bug Something isn't working label Jun 3, 2024
@mpstefan mpstefan added this to the v1.4.0 milestone Jun 3, 2024
@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days labels Jun 24, 2024
@kate-osborn kate-osborn self-assigned this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants