-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClientSettingsPolicy CRD #1793
Merged
kate-osborn
merged 1 commit into
nginxinc:main
from
kate-osborn:enh/client-settins-policy-crd
Apr 4, 2024
Merged
Add ClientSettingsPolicy CRD #1793
kate-osborn
merged 1 commit into
nginxinc:main
from
kate-osborn:enh/client-settins-policy-crd
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
New feature or request
helm-chart
Relates to helm chart
labels
Apr 1, 2024
kate-osborn
commented
Apr 1, 2024
kate-osborn
commented
Apr 1, 2024
sjberman
reviewed
Apr 1, 2024
sjberman
approved these changes
Apr 1, 2024
lucacome
approved these changes
Apr 1, 2024
pleshakov
reviewed
Apr 1, 2024
kate-osborn
force-pushed
the
enh/client-settins-policy-crd
branch
2 times, most recently
from
April 4, 2024 00:19
1ba2028
to
e858bb5
Compare
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Apr 4, 2024
ciarams87
reviewed
Apr 4, 2024
pleshakov
reviewed
Apr 4, 2024
kate-osborn
force-pushed
the
enh/client-settins-policy-crd
branch
from
April 4, 2024 19:46
c01f006
to
d7e06b1
Compare
kate-osborn
force-pushed
the
enh/client-settins-policy-crd
branch
from
April 4, 2024 20:18
d7e06b1
to
be9eae3
Compare
pleshakov
approved these changes
Apr 4, 2024
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add ClientSettingsPolicy CRD.
Problem: Users need a way to configure the behavior between the downstream client and NGF. For example, be able to set the client max body size.
Solution: Add the ClientSettingsPolicy CRD, which provides a way to configure this behavior. Note: this PR contains the CRD only. A subsequent PR will add the implementation.
Testing: Verified CRD can be installed and tested the OpenAPI schema validation.
This PR also adds the category
nginx-gateway-fabric
to the NginxGateway CRD. This allows users to look up all the api-resources related to our controller.Closes #1759
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.