-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client Settings Policy Enhancement Proposal #1692
Client Settings Policy Enhancement Proposal #1692
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note with the images; when using dark mode, the text and arrows between boxes is difficult to see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, read through all of it and it mostly made sense, won't approve for now as I will let the others get to it first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the diagrams are huge help 👍 nicely done
ec7776b
to
079a900
Compare
Should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Saylor Berman <[email protected]>
Co-authored-by: Saylor Berman <[email protected]>
Co-authored-by: bjee19 <[email protected]>
Co-authored-by: bjee19 <[email protected]>
5e78f3f
to
1412269
Compare
Problem: Need design for specifying client settings like client_max_body_size Solution: Add enhancement proposal introducing ClientSettingsPolicy.
Proposed changes
Problem: Need design for specifying client settings like
client_max_body_size
Solution: Add enhancement proposal introducing
ClientSettingsPolicy
.Enhancement Proposal: #1632
Closes #1603
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.