-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose NGINX Plus dashboard #1488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: I have approved but please review the feedback I have for the image's alt text.
Screenshots come with a maintenance cost: if the UI they are capturing is updated, all screenshots of it also need to be updated.
I would avoid using screenshots in the future, or document a procedure for routinely checking and updating the accuracy of screenshots in the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the updates look good.
does it make sense to include this port to this https://github.com/nginxinc/nginx-gateway-fabric/blob/main/site/static/img/ngf-pod.png and into architecture doc?
It it described in NIC -- https://docs.nginx.com/nginx-ingress-controller/overview/design/#the-nginx-ingress-controller-pod
@pleshakov Since it's only an N+ port, I hesitate to add to the image and main table. I could add a separate note to the architecture doc though that briefly describes. |
Problem: As a user, I want observability into the NGINX Plus configuration and metrics. Solution: By exposing the NGINX Plus dashboard, a user can easily visualize real-time metrics and information about the configuration.
e702b74
to
2a8ba19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Problem: As a user, I want observability into the NGINX Plus configuration and metrics.
Solution: By exposing the NGINX Plus dashboard, a user can easily visualize real-time metrics and information about the configuration.
Closes #1381