-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Update Helm chart instructions to avoid UX friction when using Kind #1281
Conversation
@kevin85421 We're about to migrate our docs a little bit in the next day or two, so we'll wait to rebase your change on the new structure before we look at merging it. |
Just out of curiosity, what's the reason for using |
@kevin85421 The main use case of NGINX Gateway Fabric is to get traffic into a cluster, using it as an ingress point. ClusterIP Services are for traffic within the cluster network, whereas the LB Service is for getting traffic into the cluster from an outside source. |
@kevin85421 Our docs have now been migrated if you want to rebase. The kind document now lives at |
Thank @sjberman for your reply! Recently, I have begun delving into more details about Kubernetes networking to enhance support for Ray Serve on Kubernetes (KubeRay). Therefore, some of my questions might be basic. I've come across numerous articles and videos (example) that compare the Kubernetes LoadBalancer service (OSI L4) and Ingress/Gateway (OSI L7) as alternatives. Hence, this makes me feel a bit puzzled when they are presented simultaneously. Based on your reply, I guess:
Is my understanding correct? Thanks! |
@kevin85421 Yes, you're understanding is correct. Ingress/Gateway is fronted by a load balancer for traffic incoming to the cluster, and then the Ingress/Gateway handles routing traffic to all of your backends within the cluster. |
3ed1bca
to
a5333e8
Compare
✅ Deploy Preview for nginx-gateway-fabric ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have already updated the PR. I will figure out how to build the documentation locally and ensure that it is rendered correctly. |
I followed this doc and ran |
Co-authored-by: Saylor Berman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed changes
For kind clusters, NodePort services require extra configuration and LoadBalancer services need a third-party controller like MetalLB for external IP assignment. However, the Helm chart creates a LoadBalancer service by default. Therefore, the
--wait
flag will hang until timeout.The guide running-on-kind.md asks users to create a Kind cluster by running the
make create-kind-cluster
command. However, the command neither sets theextraPortMappings
Kind configs nor installs MetalLB, so users cannot use NodePort and LoadBalancer directly after running the command.This PR suggests users disable the creation of NodePort / LoadBalancer Kubernetes service, and uses the port-forwarding command from the
running-on-kind.md
guide.Checklist
Before creating a PR, run through this checklist and mark each as complete.