Add stubbed NginxProxy CRD and watcher #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
pleshakov
suggested changes
Nov 2, 2023
We probably should, but as a separate PR into the main branch. |
kate-osborn
reviewed
Nov 2, 2023
Problem: We have two upcoming stories that require the new NginxProxy CRD in order to be worked on. Solution: To prevent one story from being blocked by the other, this work adds the new CRD with a blank spec, a controller that watches for it and triggers an update, and sets the status on the resource.
sjberman
force-pushed
the
chore/add-crd-stub
branch
from
7a51762 to
ec4c46d
Compare
kate-osborn
requested changes
Nov 3, 2023
kate-osborn
reviewed
Nov 3, 2023
kate-osborn
reviewed
Nov 3, 2023
kate-osborn
approved these changes
Nov 3, 2023
pleshakov
reviewed
Nov 3, 2023
ciarams87
pushed a commit
to ciarams87/nginx-gateway-fabric
that referenced
this pull request
Nov 17, 2023
Problem: We have two upcoming stories that require the new NginxProxy CRD in order to be worked on. Solution: To prevent one story from being blocked by the other, this work adds the new CRD with a blank spec, a controller that watches for it and triggers an update, and sets the status on the resource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: We have two upcoming stories that require the new NginxProxy CRD in order to be worked on.
Solution: To prevent one story from being blocked by the other, this work adds the new CRD with a blank spec, a controller that watches for it and triggers an update, and sets the status on the resource.
Testing: Manually verified that updates are properly handled and status is set.
Please focus on (optional): I left a TODO for whoever implements the CRD fields to add additional unit testing.