Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm-chart label to changes affecting the Helm chart #1206

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

ciarams87
Copy link
Member

Proposed changes

Problem: As an NGF developer, I want automation to add a label to any PR that changes the Helm chart, so that these changes can be reflected in a separate section in the release.

Solution: Add helm-chart section to labeler.yml and release.yml

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner October 26, 2023 16:55
@github-actions github-actions bot added the chore Pull requests for routine tasks label Oct 26, 2023
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦

@ciarams87 ciarams87 force-pushed the chore/add-helm-to-labeller branch from 42913e1 to 26181d9 Compare October 26, 2023 17:02
@sjberman sjberman enabled auto-merge (squash) October 31, 2023 16:32
@sjberman sjberman merged commit 62ec2da into nginxinc:main Oct 31, 2023
21 checks passed
@ciarams87 ciarams87 deleted the chore/add-helm-to-labeller branch November 1, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants