-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm Chart: Support extra volume mounts #1193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Oct 24, 2023
kate-osborn
requested changes
Oct 25, 2023
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
sjberman
reviewed
Oct 26, 2023
sjberman
approved these changes
Oct 31, 2023
sjberman
reviewed
Oct 31, 2023
kate-osborn
reviewed
Oct 31, 2023
kate-osborn
approved these changes
Oct 31, 2023
kate-osborn
requested changes
Oct 31, 2023
Co-authored-by: Kate Osborn <[email protected]>
Co-authored-by: Kate Osborn <[email protected]>
kate-osborn
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
helm-chart
Relates to helm chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add support for mounting additional volumes into the containers
Problem: We leverage internal certificates for communication between services and need to load the trusted root certificate into the containers. Mounting the certificate as a volume prevents us having to build our own container image.
Solution: Allows providing additional volumes to be mounted into containers, and the volume mounts to enable different combinations to be mounted in addition to the default mounts. If none are provided there is no change in the deployment
Testing: Deploy the chart with and without additional volume mounts.
Closes #1199
Checklist
Before creating a PR, run through this checklist and mark each as complete.