Rename NGINX Kubernetes Gateway

[sjberman]

Renaming NGINX Kubernetes Gateway to NGINX Gateway Fabric. NKG is renamed to NGF

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[kate-osborn]

Some instances of NGINX Gateway that need to be changed:

https://github.com/nginxinc/nginx-kubernetes-gateway/blob/3b40f0fe3602c23c8d67ec66d424cf2f28ccf4b3/cmd/gateway/commands.go#L24

https://github.com/nginxinc/nginx-kubernetes-gateway/blob/3b40f0fe3602c23c8d67ec66d424cf2f28ccf4b3/cmd/gateway/commands.go#L219

https://github.com/nginxinc/nginx-kubernetes-gateway/blob/3b40f0fe3602c23c8d67ec66d424cf2f28ccf4b3/deploy/helm-chart/values.yaml#L4

https://github.com/nginxinc/nginx-kubernetes-gateway/blob/main/docs/cli-help.md#static-mode (in the description for gatewayclass)

[bjee19]

Is this a place that should be updated too? "NGINX Gateway" -> "NGINX Gateway Fabric"

https://github.com/nginxinc/nginx-kubernetes-gateway/blob/d73377c7407af47a40a1090b9545561c1c7d4d71/internal/mode/static/state/change_processor.go#L199

[bjee19]

There are a few more instances of using NGINX Gateway in comments here (5 instances):

https://github.com/nginxinc/nginx-kubernetes-gateway/blob/d4440cddb6b1bbf38c8a3ef1863f2058b652a110/internal/mode/static/state/graph/graph.go#L29

One here:
https://github.com/nginxinc/nginx-kubernetes-gateway/blob/d4440cddb6b1bbf38c8a3ef1863f2058b652a110/conformance/provisioner/README.md#L15

[bjee19]

Is this something that should be changed also? "nginx gateway Pod"

https://github.com/nginxinc/nginx-kubernetes-gateway/blob/d4440cddb6b1bbf38c8a3ef1863f2058b652a110/docs/guides/routing-traffic-to-your-app.md?plain=1#L361

If so, this would need to be changed too
https://github.com/nginxinc/nginx-kubernetes-gateway/blob/d4440cddb6b1bbf38c8a3ef1863f2058b652a110/docs/developer/testing.md?plain=1#L82

[bjee19]

https://github.com/nginxinc/nginx-kubernetes-gateway/blob/af899e181ac63280685177e548b3379c60d4b861/cmd/gateway/commands.go#L244

and the next couple lines

[kate-osborn]

https://github.com/nginxinc/nginx-kubernetes-gateway/blob/af899e181ac63280685177e548b3379c60d4b861/cmd/gateway/commands.go#L244

and the next couple lines

Ty for catching. I forgot I added some references:

cmd/gateway/commands.go:244:            "Disable leader election. Leader election is used to avoid multiple replicas of the NGINX Kubernetes Gateway"+
cmd/gateway/commands.go:246:                    "all replicas of NGINX Kubernetes Gateway will update the statuses of the Gateway API resources.",
deploy/helm-chart/values.yaml:16:  ## The number of replicas of the NGINX Kubernetes Gateway Deployment.
deploy/helm-chart/values.yaml:20:    ## Enable leader election. Leader election is used to avoid multiple replicas of the NGINX Kubernetes Gateway
deploy/helm-chart/values.yaml:21:    ## reporting the status of the Gateway API resources. If not enabled, all replicas of NGINX Kubernetes Gateway

[bjee19]

looked through each file, hopefully if we missed something we'll catch it later!