Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Programmed Condition in Gateway Status #610

Closed
Tracked by #305
, #612
...
pleshakov opened this issue May 3, 2023 · 2 comments · Fixed by #658
Closed
Tracked by #305
, #612
...

Set Programmed Condition in Gateway Status #610

pleshakov opened this issue May 3, 2023 · 2 comments · Fixed by #658
Assignees
@sjberman
Labels
area/gateway/core Relates to all Core features of Gateway conformance Relates to passing Gateway API conformance tests enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented.
Milestone
v0.5.0

Comments

@pleshakov
Copy link
Contributor

pleshakov commented May 3, 2023 •
edited
Loading

Gateway API prescribes that Programmed condition is present on Gateway resources

https://github.com/kubernetes-sigs/gateway-api/blob/c67f3fd31976ea74ea06a78c2a88ae38df95a41d/apis/v1beta1/gateway_types.go#L519-L569

Note: this is required by conformance tests https://github.com/kubernetes-sigs/gateway-api/blob/6efcfdf8aff7aa7c3ed8deb956e5b93eed779234/conformance/utils/kubernetes/helpers.go#L216

Acceptance Criteria:
@kate-osborn
Copy link
Contributor

@pleshakov is this a blocker for running conformance tests?

@pleshakov
Copy link
Contributor Author

@kate-osborn
yep. added a note.

@ja20222 ja20222 added area/gateway/core Relates to all Core features of Gateway and removed proposal labels May 4, 2023
@ja20222 ja20222 added this to the v0.4.0 milestone May 4, 2023
@ja20222 ja20222 added enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. labels May 4, 2023
@pleshakov pleshakov added the conformance Relates to passing Gateway API conformance tests label May 10, 2023
This was referenced May 10, 2023
Closed
Closed
@mpstefan mpstefan modified the milestones: v0.4.0, v0.5.0 May 17, 2023
@sjberman sjberman self-assigned this May 18, 2023
@sjberman sjberman moved this from 🆕 New to 🔖 To Do in NGINX Gateway Fabric May 18, 2023
@sjberman sjberman moved this from 🔖 To Do to 🏗 In Progress in NGINX Gateway Fabric May 18, 2023
@sjberman sjberman mentioned this issue May 22, 2023
Merged
6 tasks
@sjberman sjberman moved this from 🏗 In Progress to 👀 In Review in NGINX Gateway Fabric May 22, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjberman sjberman

Labels
area/gateway/core Relates to all Core features of Gateway conformance Relates to passing Gateway API conformance tests enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented.
Projects
NGINX Gateway Fabric
Archived in project
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Set Gateway Programmed condition sjberman/nginx-gateway-fabric
5 participants
@pleshakov @mpstefan @sjberman @kate-osborn @ja20222