Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify NKG against community conformance tests #305

Closed
8 tasks done
f5yacobucci opened this issue Nov 14, 2022 · 3 comments
Closed
8 tasks done

Verify NKG against community conformance tests #305

f5yacobucci opened this issue Nov 14, 2022 · 3 comments
Labels
conformance Relates to passing Gateway API conformance tests enhancement New feature or request epic Represents an epic. Contains sub-issues refined Requirements are refined and the issue is ready to be implemented. tests Pull requests that update tests
Milestone

Comments

@f5yacobucci
Copy link
Contributor

f5yacobucci commented Nov 14, 2022

The Gateway community maintains a set of conformance tests to inform users and implementations. As a first step in improving NKG compliance and quality, we need to verify our implementation for common expectations and begin automating our usage of these tests.

See here: https://gateway-api.sigs.k8s.io/concepts/conformance/

Due to the early nature of NKG's implementation, we may need to target tests to specific areas and work towards running a complete set.

Tasks

Preview Give feedback
  1. area/gateway/core conformance enhancement refined
    sjberman
  2. proposal
  3. area/gateway/core conformance enhancement refined
    kate-osborn
  4. area/control-plane conformance refined
    pleshakov
  5. area/gateway/core conformance enhancement refined
    sjberman
  6. area/httproute/core conformance enhancement refined
    kate-osborn
  7. refined release-engineering
    vepatel
  8. refined release-engineering
    ciarams87

A/C:

  • Run conformance tests and propose a realistic set to build upon.
  • File tickets for features we do support that fail tests.
  • Build a pipeline to automate conformance test runs. Make sure there's at least one test enabled and passing
@f5yacobucci f5yacobucci added this to the v0.3.0 milestone Nov 14, 2022
@kate-osborn
Copy link
Contributor

I found some blockers to running the conformance tests against NKG: #370 #369 #368

@kate-osborn kate-osborn added enhancement New feature or request tests Pull requests that update tests labels Mar 21, 2023
@kate-osborn kate-osborn modified the milestones: v0.3.0, v1.0.0, v0.4.0 Mar 21, 2023
@kate-osborn kate-osborn added the blocked Blocked by other issue label Mar 24, 2023
@kate-osborn
Copy link
Contributor

This issue is blocked by #508

@pleshakov pleshakov added epic Represents an epic. Contains sub-issues and removed proposal blocked Blocked by other issue labels Apr 26, 2023
@pleshakov pleshakov added the conformance Relates to passing Gateway API conformance tests label May 10, 2023
@mpstefan mpstefan added the refined Requirements are refined and the issue is ready to be implemented. label May 16, 2023
@mpstefan mpstefan moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric May 17, 2023
@sjberman sjberman closed this as completed Jul 7, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in NGINX Gateway Fabric Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conformance Relates to passing Gateway API conformance tests enhancement New feature or request epic Represents an epic. Contains sub-issues refined Requirements are refined and the issue is ready to be implemented. tests Pull requests that update tests
Projects
Archived in project
Development

No branches or pull requests

5 participants