Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike: Upsert and Delete should preempt updates with no changes #552

Open
ja20222 opened this issue Apr 5, 2023 · 2 comments
Open

Spike: Upsert and Delete should preempt updates with no changes #552

ja20222 opened this issue Apr 5, 2023 · 2 comments
Labels
area/control-plane General control plane issues backlog Currently unprioritized work. May change with user feedback or as the product progresses.

Comments

@ja20222
Copy link

ja20222 commented Apr 5, 2023 •
edited by pleshakov
Loading

Do not generate the configuration if there have be no operative changes in the k8s resources

Acceptance criteria:

  • evaluate options for achieving this
  • capture them in a doc
  • make a decision
  • define work
@pleshakov pleshakov added the area/control-plane General control plane issues label Apr 7, 2023
@pleshakov pleshakov added this to the v1.0.0 milestone Apr 7, 2023
@pleshakov pleshakov added enhancement New feature or request and removed enhancement New feature or request labels Apr 7, 2023
@pleshakov pleshakov changed the title Enhancement: Upsert and Delete should preempt updates with no changes Spike: Upsert and Delete should preempt updates with no changes Apr 7, 2023
@kate-osborn kate-osborn mentioned this issue Jun 27, 2023
Merged
6 tasks
@mpstefan mpstefan modified the milestones: v1.0.0, v1.0.1 Aug 11, 2023
@mpstefan mpstefan modified the milestones: v1.0.1, v1.3.0 Sep 22, 2023
@mpstefan
Copy link
Collaborator

Not enough information to prioritize.

@pleshakov Can you add context?

Who cares about this?
What configuration?
Why do we want this? What impact does it have?

@mpstefan mpstefan removed this from the v1.3.0 milestone Mar 13, 2024
@mpstefan mpstefan added the backlog Currently unprioritized work. May change with user feedback or as the product progresses. label Mar 13, 2024
@pleshakov
Copy link
Contributor

This is related to #1664 but different.

An example of the problem that this issue considers:
If some resource like HTTPRoute changes (ex - a new parentRef was added for a non-NGF Gateway), but the generated configuration is the same as the current one, we should skip reloading NGINX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/control-plane General control plane issues backlog Currently unprioritized work. May change with user feedback or as the product progresses.
Projects
NGINX Gateway Fabric
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pleshakov @mpstefan @ja20222