Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NGF is reloading NGINX when there are no config changes #1664

Open
4 tasks
ciarams87 opened this issue Mar 11, 2024 · 0 comments
Open
4 tasks

NGF is reloading NGINX when there are no config changes #1664

ciarams87 opened this issue Mar 11, 2024 · 0 comments
Labels
area/performance Performance related backlog Currently unprioritized work. May change with user feedback or as the product progresses. bug Something isn't working help wanted Extra attention is needed

Comments

@ciarams87
Copy link
Member

ciarams87 commented Mar 11, 2024 •
edited
Loading

Describe the bug
We are reloading after reconciling resources even when there is no accepted Gateway and no config being generated.

To Reproduce

Deploy a HTTPRoute referring to a Gateway that has not yet been created. Observe that NGINX config files are being regenerated and NGINX is reloaded.

Expected behavior
NGINX should not be reloaded when no NGINX config changes have occurred.

Tasks
Preview Give feedback
  1. NGF is reloading NGINX for BackendTLSPolicy with no accepted Gateway #1577
    area/performance backlog bug
  2. NGF is reloading NGINX for ReferenceGrants with no accepted Gateway #1124
    area/performance backlog bug good first issue temp
  3. NGF is reloading NGINX for HTTPRoutes with no accepted Gateway #1123
    area/performance backlog bug good first issue temp
    kate-osborn
@pleshakov pleshakov mentioned this issue Mar 13, 2024
Open
@mpstefan mpstefan added help wanted Extra attention is needed bug Something isn't working area/performance Performance related backlog Currently unprioritized work. May change with user feedback or as the product progresses. labels Mar 25, 2024
@ciarams87 ciarams87 mentioned this issue May 30, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/performance Performance related backlog Currently unprioritized work. May change with user feedback or as the product progresses. bug Something isn't working help wanted Extra attention is needed
Projects
NGINX Gateway Fabric
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpstefan @ciarams87