-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change validation in Duration type in CRDs and NGF #2525
Change validation in Duration type in CRDs and NGF #2525
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2525 +/- ##
=======================================
Coverage 89.34% 89.34%
=======================================
Files 100 100
Lines 7628 7630 +2
Branches 50 50
=======================================
+ Hits 6815 6817 +2
Misses 756 756
Partials 57 57 ☔ View full report in Codecov by Sentry. |
@bjee19 can you update the Release Notes section in the PR description? We will want to release note this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the Release Notes section is updated
21b7ed0
to
0429c30
Compare
0429c30
to
54d0e29
Compare
Proposed changes
Problem: Duration type in crds was limited to being in seconds or milliseconds. This is inconvenient with the keepalive_time nginx directive which defaults to 1 hour.
Solution: Relax the validation to allow for minutes and hours.
Testing: Tested that crds can use minutes and hours for their duration fields.
Closes #2532
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.