Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax validation on Duration type in CRDs to include minutes and hours units #2532

Closed
bjee19 opened this issue Sep 11, 2024 · 0 comments · Fixed by #2525
Closed

Relax validation on Duration type in CRDs to include minutes and hours units #2532

bjee19 opened this issue Sep 11, 2024 · 0 comments · Fixed by #2525
Assignees
Labels
enhancement New feature or request

Comments

@bjee19
Copy link
Contributor

bjee19 commented Sep 11, 2024

Currently the Duration type in our CRDs have validation to only allow seconds and milliseconds units. This is okay, however for an nginx directive like keepalive_time, the default is 1h. This means if a user were to try and set that nginx directive through a policy CRD, for them to set realistic values, they would need to express a time like 1 hour in seconds which would be inconvenient and confusing.

@bjee19 bjee19 added the enhancement New feature or request label Sep 11, 2024
@bjee19 bjee19 self-assigned this Sep 11, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant