Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NFR scale test to GitHub actions pipeline #1927

Closed
pleshakov opened this issue May 2, 2024 · 0 comments · Fixed by #2024
Closed

Add NFR scale test to GitHub actions pipeline #1927

pleshakov opened this issue May 2, 2024 · 0 comments · Fixed by #2024
Assignees
@pleshakov
Labels
refined Requirements are refined and the issue is ready to be implemented. tests Pull requests that update tests
Milestone
v1.3.0

Comments

@pleshakov
Copy link
Contributor

pleshakov commented May 2, 2024 •
edited
Loading

#1926 adds scale test

To run it successfully by NGF pipeline, the GKE cluster must meet the following requirements:

  • A Kubernetes cluster with 12 nodes on GKE
  • Node: n2d-standard-16 (16 vCPU, 64GB memory)

Acceptance criteria:

  • Ensure scale test successfully runs by NGF pipeline
  • Ensure test runs for both NGINX and NGINX Plus images
@pleshakov pleshakov added the tests Pull requests that update tests label May 2, 2024
@pleshakov pleshakov added this to the v1.3.0 milestone May 2, 2024
@pleshakov pleshakov mentioned this issue May 2, 2024
Merged
6 tasks
@sindhushiv sindhushiv added the blocked Blocked by other issue label May 15, 2024
@ciarams87 ciarams87 removed the blocked Blocked by other issue label May 20, 2024
@mpstefan mpstefan added the refined Requirements are refined and the issue is ready to be implemented. label May 20, 2024
@pleshakov pleshakov self-assigned this May 20, 2024
@sindhushiv sindhushiv moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric May 20, 2024
@pleshakov pleshakov changed the title Ensure scale test successfully runs by NGF pipeline Ensure scale test runs by GitHub pipeline May 23, 2024
@pleshakov pleshakov changed the title Ensure scale test runs by GitHub pipeline Add NFR scale test to GitHub actions pipeline May 23, 2024
pleshakov added a commit that referenced this issue May 23, 2024
@pleshakov
Add NFR scale test to GitHub actions pipeline
2c346a8 
Problem:
Scale test is not part of Github actions pipeline

Solution:
- Add NFR scale test to GitHub actions pipeline along other NFR tests.
- Increase the size of the cluster used for NFR tests, as the scale
  test requires bigger size.

Testing:
- Successfully run with NGINX -- #2002
- Successfully run with NGINX Plus -- #2017

Some scale test issues were discovered:
- #2023
- #2009

Closes #1927
@pleshakov pleshakov mentioned this issue May 23, 2024
Merged
6 tasks
pleshakov added a commit that referenced this issue May 23, 2024
@pleshakov
Add NFR scale test to GitHub actions pipeline (#2024)
3095a23 
Problem:
Scale test is not part of Github actions pipeline

Solution:
- Add NFR scale test to GitHub actions pipeline along other NFR tests.
- Increase the size of the cluster used for NFR tests, as the scale
  test requires bigger size.

Testing:
- Successfully run with NGINX -- #2002
- Successfully run with NGINX Plus -- #2017

Some scale test issues were discovered:
- #2023
- #2009

Closes #1927
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in NGINX Gateway Fabric May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pleshakov pleshakov

Labels
refined Requirements are refined and the issue is ready to be implemented. tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Archived in project
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

Add NFR scale test to GitHub actions pipeline nginxinc/nginx-gateway-fabric
4 participants
@pleshakov @mpstefan @sindhushiv @ciarams87