Skip to content

Commit

Permalink
Remove njs-modules configmap (#959)
Browse files Browse the repository at this point in the history
Problem: PR #934 did not remove the njs-modules ConfigMap 
and they are some lingering references to it.

Solution: Remove the njs modules ConfigMap and remove references.
  • Loading branch information
kate-osborn authored Aug 11, 2023
1 parent 1f47bc0 commit d4ce16b
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 222 deletions.
1 change: 0 additions & 1 deletion .yamllint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ rules:
check-multi-line-strings: true
ignore: |
deploy/manifests/nginx-gateway.yaml
deploy/manifests/njs-modules.yaml
key-duplicates: enable
key-ordering: disable
line-length:
Expand Down
214 changes: 0 additions & 214 deletions deploy/manifests/njs-modules.yaml

This file was deleted.

7 changes: 0 additions & 7 deletions internal/mode/static/nginx/modules/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,3 @@ This project uses [prettier](https://prettier.io/) to lint and format the JavaSc
```shell
npm run format
```

## Generate the ConfigMap yaml

The NJS modules are mounted to the NGINX container using a ConfigMap. Once you have completed your code changes, ensure
the [njs-modules.yaml](/deploy/manifests/njs-modules.yaml) and
[NJS ConfigMap Helm template](/deploy/helm-chart/templates/njs-modules.yaml) are updated to reflect the new code. See
[Update NJS module ConfigMaps](/docs/developer/quickstart.md#update-njs-module-configmaps).

0 comments on commit d4ce16b

Please sign in to comment.