Skip to content

Commit

Permalink
Remove global waitgroup
Browse files Browse the repository at this point in the history
  • Loading branch information
sjberman committed Jul 24, 2024
1 parent 5f10dd6 commit 6c4657e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tests/suite/scale_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,6 @@ var _ = Describe("Zero downtime scale test", Ordered, Label("nfr", "zero-downtim
resultsDir string
ngfDeploymentName string
ns core.Namespace
wg sync.WaitGroup
metricsCh chan *metricsResults

files = []string{
Expand Down Expand Up @@ -998,6 +997,7 @@ var _ = Describe("Zero downtime scale test", Ordered, Label("nfr", "zero-downtim

testFileNamePrefix := formatTestFileNamePrefix("gradual-scale-up", test.valuesFile)

var wg sync.WaitGroup
for _, test := range trafficConfigs {
wg.Add(1)
go func(cfg trafficCfg) {
Expand Down Expand Up @@ -1049,6 +1049,7 @@ var _ = Describe("Zero downtime scale test", Ordered, Label("nfr", "zero-downtim
// total amount of time we send traffic
waitTime := time.Duration(test.numReplicas) * terminationTime

var wg sync.WaitGroup
for _, test := range trafficConfigs {
wg.Add(1)
go func(cfg trafficCfg) {
Expand Down Expand Up @@ -1121,6 +1122,7 @@ var _ = Describe("Zero downtime scale test", Ordered, Label("nfr", "zero-downtim

testFileNamePrefix := formatTestFileNamePrefix("abrupt-scale-up", test.valuesFile)

var wg sync.WaitGroup
for _, test := range trafficConfigs {
wg.Add(1)
go func(cfg trafficCfg) {
Expand Down Expand Up @@ -1152,6 +1154,7 @@ var _ = Describe("Zero downtime scale test", Ordered, Label("nfr", "zero-downtim

testFileNamePrefix := formatTestFileNamePrefix("abrupt-scale-down", test.valuesFile)

var wg sync.WaitGroup
for _, test := range trafficConfigs {
wg.Add(1)
go func(cfg trafficCfg) {
Expand Down

0 comments on commit 6c4657e

Please sign in to comment.