Support match in TransportServer health checks #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
soneillf5
reviewed
May 27, 2021
soneillf5
suggested changes
May 27, 2021
soneillf5
reviewed
May 31, 2021
soneillf5
suggested changes
May 31, 2021
vepatel
reviewed
Jun 1, 2021
| @@ -407,3 +408,121 @@ def test_tcp_request_load_balanced_method( | |||
| client.close() | |||
|
|
|||
| assert len(endpoints) is 3 | |||
|
|
|||
| @pytest.mark.skip_for_nginx_oss | |||
| def test_tcp_passing_healthcheck_with_match( | |||
There was a problem hiding this comment.
@pleshakov these tests also looks like a decent candidates to use parameterization to pass various ts/cases, see: https://github.com/nginxinc/kubernetes-ingress/blob/master/tests/suite/test_ingress_mtls.py#L82
There was a problem hiding this comment.
makes sense. let me know about this https://github.com/nginxinc/kubernetes-ingress/pull/1633/files#r643518158
There was a problem hiding this comment.
Yeah that's fine for now that its added and working but we don't need to verify all the attribs as nginx plus is doing lb and the UI is provided by the same.
vepatel
reviewed
Jun 1, 2021
| @@ -526,10 +526,13 @@ func TestGenerateUnixSocket(t *testing.T) { | |||
|
|
|||
| func TestGenerateTransportServerHealthChecks(t *testing.T) { | |||
| upstreamName := "dns-tcp" | |||
| generatedUpsteamName := "ts_namespace_name_dns-tcp" | |||
There was a problem hiding this comment.
is there one for dns-udp too?
soneillf5
approved these changes
Jun 2, 2021
vepatel
approved these changes
Jun 2, 2021
pleshakov
force-pushed
the
feature/ts-hc-match
branch
from
699597d
to
123003b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support match in TransportServer health checks
Based on the original work from @soneillf5