Add gitlab pipeline and remove plus building from github #1601
Conversation
ciarams87
force-pushed
the
chore/create-gitlab-pipeline
branch
3 times, most recently
from
fd3c506
to
6703ad7
Compare
ciarams87
changed the title
| needs: [binary, unit-tests] | ||
| if: | ||
| github.event.pull_request.head.repo.full_name == 'nginxinc/kubernetes-ingress' || |
There was a problem hiding this comment.
Wasn't this here to prevent builds from forks? We don't need it anymore?
There was a problem hiding this comment.
As far as I recall, we wanted to skip smoke tests from forks because they couldn't access secrets. We're not using secrets here any more, so smoke tests on OSS is probably a good idea before we review anything.
|
I've noticed that the link to the pipeline doesn't bring you directly to the run if gitlab needs to reauthenticate, but works fine after that. We should report a bug 😄 |
This comment has been minimized.
This comment has been minimized.
ciarams87
force-pushed
the
chore/create-gitlab-pipeline
branch
3 times, most recently
from
71f0e1e
to
b6eee90
Compare
| - os: ubuntu-20.04 | ||
| image: debian-plus | ||
| tag: ${{ github.sha }} | ||
| - image: alpine |
There was a problem hiding this comment.
Should we run all tests on debian only? because of runs-on: ubuntu-20.04?
There was a problem hiding this comment.
runs-on: ubuntu-20.04 is the just the runner OS - we always used ubuntu-20.04 runner for all of our jobs. The image is which IC image version we are using in the KinD cluster.
| @@ -0,0 +1,7 @@ | |||
| kind: Cluster | |||
There was a problem hiding this comment.
is this going outside of pipleines?
There was a problem hiding this comment.
It's so we are using the same configuration in github and gitlab
| @@ -0,0 +1,14 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Same answer as above 👍🏼
ciarams87
force-pushed
the
chore/create-gitlab-pipeline
branch
2 times, most recently
from
ac23bc5
to
7a6babf
Compare
ciarams87
force-pushed
the
chore/create-gitlab-pipeline
branch
from
7a6babf
to
e134841
Compare
| @@ -362,70 +254,15 @@ jobs: | |||
| path: ${{ github.workspace }}/tests/tests-${{ steps.k8s.outputs.cluster }}.html | |||
| if: always() | |||
|
|
|||
There was a problem hiding this comment.
So much removed! Brilliant!
Proposed changes
Remove plus building from GitHub; remove some of the CI logic from the workflows to the test folder; add a gitlab-ci.yml file for the Gitlab integration,
Checklist
Before creating a PR, run through this checklist and mark each as complete.