Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some App Protect logs links #1594

Merged
merged 1 commit into from
Jun 3, 2021
Merged

fix some App Protect logs links #1594

merged 1 commit into from
Jun 3, 2021

Conversation

shaggy245
Copy link
Contributor

@shaggy245 shaggy245 commented May 13, 2021 •
edited
Loading

Proposed changes

Fixing some broken links in App Protect logging documentation.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@netlify
Copy link

netlify bot commented May 13, 2021 •
edited
Loading

Deploy request for nginx-kubernetes-ingress accepted.

Accepted with commit d75ef66

https://app.netlify.com/sites/nginx-kubernetes-ingress/deploys/609cb591c48d6e00070f9835

@pleshakov pleshakov added the documentation Pull requests/issues for documentation label May 14, 2021
@pleshakov pleshakov requested review from rafwegv, lucacome and pleshakov and removed request for lucacome May 14, 2021 22:41
rafwegv
rafwegv approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@rafwegv rafwegv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pleshakov pleshakov merged commit a349987 into nginxinc:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafwegv rafwegv rafwegv approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaggy245 @pleshakov @rafwegv