-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional sourced entrypoint files #687
Conversation
See #431 for some discussion on that matter. |
Hmm.. you are right. I can add separate case for eg. |
I actually have that patch already done, just not published. I would like some input on the PR i linked first if that would work for their use cases as well. (I don't see why not, but who knows). |
I cannot see any PR linked here nor in issue you linked here. You mean you want my feedback in the issue? Sure! |
This allows reusing variables declared between entrypoint scripts
Hello. Is there any progress on merging this or providing similar solution? This is kinda blocking (as I don't want to implement workaround temp solutions if possible to merge this) for my other changes in funkwhale project. |
Thanks for the PR, implementation and reminders! I've manually adapted the patch and pushed it in 6675128 |
Thanks for this awesome feature! @thresheek can you tell when will it be released as 1.24? |
Hi @l1553k! It will be available with the next 1.23 release, however we don't have a strict ETA for it yet. Hopefully in two or three weeks. |
@thresheek I've patched the docker-entrypoint.sh in a local setup with the current 1.23.1 release. I've noticed that |
Oh indeed, it seems debian's dash doesnt support |
Fixed in cc7ca22 - thanks for the notification @blubberblah ! |
This allows reusing variables declared between entrypoint scripts.
You can create eg. entrypoint starting with 00 to declare some dynamic variables and then use those in envsubst predefined entrypoint.