Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional sourced entrypoint files #687

Closed
wants to merge 1 commit into from
Closed

Additional sourced entrypoint files #687

wants to merge 1 commit into from

Conversation

JuniorJPDJ
Copy link
Contributor

This allows reusing variables declared between entrypoint scripts.

You can create eg. entrypoint starting with 00 to declare some dynamic variables and then use those in envsubst predefined entrypoint.

@thresheek
Copy link
Collaborator

See #431 for some discussion on that matter.

@JuniorJPDJ
Copy link
Contributor Author

Hmm.. you are right. I can add separate case for eg. .envsh and that would be sourced. Order will be preserved, compatibility will be preserved..

@thresheek
Copy link
Collaborator

I actually have that patch already done, just not published. I would like some input on the PR i linked first if that would work for their use cases as well. (I don't see why not, but who knows).

@JuniorJPDJ
Copy link
Contributor Author

I cannot see any PR linked here nor in issue you linked here. You mean you want my feedback in the issue? Sure!

This allows reusing variables declared between entrypoint scripts
@JuniorJPDJ JuniorJPDJ changed the title Source entrypoint files Additional sourced entrypoint files Jul 20, 2022
@JuniorJPDJ
Copy link
Contributor Author

JuniorJPDJ commented Sep 4, 2022

Hello. Is there any progress on merging this or providing similar solution? This is kinda blocking (as I don't want to implement workaround temp solutions if possible to merge this) for my other changes in funkwhale project.

@thresheek
Copy link
Collaborator

Thanks for the PR, implementation and reminders!

I've manually adapted the patch and pushed it in 6675128

@thresheek thresheek closed this Sep 9, 2022
@l1553k
Copy link

l1553k commented Sep 15, 2022

Thanks for this awesome feature! @thresheek can you tell when will it be released as 1.24?

@thresheek
Copy link
Collaborator

Hi @l1553k! It will be available with the next 1.23 release, however we don't have a strict ETA for it yet. Hopefully in two or three weeks.

@blubberblah
Copy link

Thanks for the PR, implementation and reminders!

I've manually adapted the patch and pushed it in 6675128

@thresheek I've patched the docker-entrypoint.sh in a local setup with the current 1.23.1 release. I've noticed that source isn't functioning with /bin/sh but, it works if I change the shell to /bin/bash. Not sure if this can be an issue with the next build.

@thresheek
Copy link
Collaborator

thresheek commented Sep 27, 2022

Oh indeed, it seems debian's dash doesnt support source. Thanks!

@thresheek
Copy link
Collaborator

Fixed in cc7ca22 - thanks for the notification @blubberblah !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants