Add 'nginx_install_epel_release' feature flag to disable the installation of epel-release if so desired #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion of epel-release if so desired
alessfg
approved these changes
Jun 14, 2021
alessfg
changed the title
alessfg
pushed a commit
that referenced
this pull request
Jun 14, 2021
…tion of epel-release if so desired (#421) Co-authored-by: Jurgen Verhasselt <[email protected]>
|
As an FYI, I took the liberty of updating the Changelog on this PR myself 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change adds a
nginx_install_epel_releasefeature flag which allowsepel-releaseto not be installed by this role if so desired.This feature flag addresses a need where the epel repository config is managed by other means and should not be configured by this role in order to install Nginx or it's modules. The default behavior of the role is unaltered.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
defaults/main/*.yml,README.mdandCHANGELOG.md)Sidenote on Molecule tests, as a test for setting
nginx_install_epel_releaseto false would effectively require current tests to be disabled, and as the default behavior is not altered, no additional tests have been added.