Correct runtime error during cleanup.

[pecastro]

TASK [ansible-role-nginx-config : Remove NGINX config files] *******************************************************************************************************************************************************
Monday 27 May 2024 11:53:13 +0100 (0:00:00.029) 0:00:14.736 ************
fatal: [localhost]: FAILED! => {"msg": "'dict object' has no attribute 'results'. 'dict object' has no attribute 'results'"}

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete:

• I have read the CONTRIBUTING document.
• I have added Molecule tests that prove my fix is effective or that my feature works.
• I have checked that any relevant Molecule tests pass after adding my changes.
• I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md).

[github-actions]

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
_{Posted by the CLA Assistant Lite bot.}

[pecastro]

recheck

[pecastro]

I have hereby read the F5 CLA and agree to its terms

[pecastro]

recheck

[pecastro]

recheck

[pecastro]

The error https://github.com/nginxinc/ansible-role-nginx-config/actions/runs/9254016965/job/25467668666?pr=429#step:6:375
seems to be related to the NGINX certificate which is totally unrelated to the fix contained in the this MR.

[alessfg]

You are right - I recently expanded the suite of tests and I forgot to exclude some tests from external PRs. I'll submit a fix asap.

In the meantime I'd appreciate if you could make a couple updates to your PR 😄

[alessfg]

Tests should be passing!

[pecastro]

recheck

[alessfg]

Can you fix the linter error and remove the double quotes surrounding the conditionals? And can you update the Changelog? Thanks! I forgot to mention that in my previous review 😅

[pecastro]

recheck

[pecastro]

@alessfg What are we missing here? Pipeline doesn't move on ...

[alessfg]

I need to manually run the pipeline for external PRs! The recheck comment only works with the CLA action :)

[alessfg]

FYI, there was an update to the nginx signing keys two days ago and until nginxinc/ansible-role-nginx#719 is merged and this role updated to use the latest commit, the pipeline here will fail.

[pecastro]

nginxinc/ansible-role-nginx#719 has been merged and I don't see anywhere in the code a reference to that repo. 🤷

[alessfg]

The role installs the latest release of the NGINX role as part of the CI/CD pipeline (see https://github.com/nginxinc/ansible-role-nginx-config/blob/main/molecule/common/requirements/oss_requirements.yml). A new release needs to be created and this role updated to use that release before tests here will pass.

[pecastro]

I get you now. So this is blocked.

[alessfg]

Finally got around merging this. Thanks again for the PR!