Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license removal bug and prepare 0.3.1 release #32

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Fix license removal bug and prepare 0.3.1 release #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d04ee3
Update CHANGELOG.md
alessfg Sep 22, 2020
bfdd910
Fix license removal issue
alessfg Sep 22, 2020
b14636b
Update CHANGELOG.md
alessfg Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# Changelog

## 0.3.1 (Unreleased)
## 0.3.1 (September 22, 2020)

FEATURES:

* Two new variables have been introduced:
* `nginx_app_protect_service_modify` -- Setting this variable to true/false will determine whether the default service timeout value gets modified.
* `nginx_app_protect_log_policy_target` -- This variable is intended as an eventual replacement for `nginx_app_protect_log_policy_syslog_target` and allows using different destinations for NGINX App Protect's log files.

ENHANCEMENTS:

Expand All @@ -9,7 +15,6 @@ ENHANCEMENTS:
BUG FIXES:

* Rename handlers to use more specific role related naming and prevent namespace collision issues.
* Add a `nginx_app_protect_service_modify` variable to revert a breaking change introduced in 0.3.0 where timeouts would not be set by default.
* Set NGINX handler to `state: restarted` to prevent some compatibility issues when NGINX App Protect is installed on an instance already running NGINX beforehand.
* Using `update_cache: true` by itself in the `apt` module is not always idempotent. Moved the NGINX App Protect installation task to a corresponding `apt` or `yum` module to avoid this scenario.

Expand All @@ -19,6 +24,10 @@ DEPRECATION WARNING:

* The ability to create an NGINX config including some basic App Protect directives has migrated to the NGINX config role available [here](https://github.com/nginxinc/ansible-role-nginx-config). Any new issues or PRs related to configuring NGINX App Protect directives should be submitted in the new NGINX Config repository. New issues or PRs related to configuring NGINX App Protect directives submitted in this repository will not be worked on. The NGINX App Protect directives configuration functionalities included in this role will be removed in an upcoming release.

BREAKING CHANGES:

* `nginx_app_protect_delete_license` has been renamed to `nginx_app_protect_remove_license`.

FEATURES:

* A new variable has been introduced:
Expand Down
2 changes: 1 addition & 1 deletion tasks/install/remove-license.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
nginx_app_protect_license_status: absent

- name: Delete repository data
include_tasks: "{{ role_path }}/tasks/install/setup-{{ ansible_facts['os_family'] | lower }}.yml"
include_tasks: "{{ role_path }}/tasks/install/install-{{ ansible_facts['os_family'] | lower }}.yml"

- name: Delete NGINX App Protect license
file:
Expand Down