Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix occasional update_cache idempotence failure #31

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Sep 22, 2020

Proposed changes

Using update_cache: true by itself in the apt module is not always idempotent. Moved the NGINX App Protect installation task to a corresponding apt or yum module to avoid this scenario.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that all Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main.yml, README.md and CHANGELOG.md)

@alessfg alessfg merged commit 3e5fad6 into main Sep 22, 2020
@alessfg alessfg deleted the update-cache-not-idempotent branch September 22, 2020 17:10
@alessfg alessfg added the bug Something isn't working label May 17, 2021
@alessfg alessfg added this to the 0.3.1 milestone May 17, 2021
@alessfg alessfg self-assigned this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants