Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Ansible facts from dot to array notation #237

Merged
merged 7 commits into from
Jan 29, 2023
Merged

Refactor Ansible facts from dot to array notation #237

merged 7 commits into from
Jan 29, 2023

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Jan 29, 2023 •
edited
Loading

Proposed changes

Refactor Ansible facts from dot to array notation to keep in with the standards set by the other roles in the Ansible NGINX core collection.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main.yml, README.md and CHANGELOG.md)

@alessfg
Check distribution and validate role variables
d2369a2 
* Validate that various role variables have been set to one of the allowed values.
* Refactor the distribution check yet again and check if your distribution's architecture is supported.
@alessfg
Update main.yml
b0b2206
@alessfg
fixes
694de09
@alessfg
Refactor Ansible facts from dot to array notation
42cefb9
@alessfg
Update CHANGELOG.md
23e66d7
@alessfg alessfg requested a review from aknot242 as a code owner January 29, 2023 16:59
@alessfg alessfg self-assigned this Jan 29, 2023
@alessfg alessfg changed the title Check distribution and validate role variables Refactor Ansible facts from dot to array notation Jan 29, 2023
@alessfg alessfg added the feature New feature or request label Jan 29, 2023
@alessfg alessfg added this to the 0.8.2 milestone Jan 29, 2023
@alessfg alessfg added enhancement Enhance/improve an existing feature and removed feature New feature or request labels Jan 29, 2023
@alessfg alessfg merged commit 3e4f941 into main Jan 29, 2023
@alessfg alessfg deleted the refactor-ansible-facts branch January 29, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknot242 aknot242 Awaiting requested review from aknot242

Assignees

@alessfg alessfg

Labels
enhancement Enhance/improve an existing feature
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@alessfg