Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check distribution and validate role variables #236

Merged
merged 3 commits into from
Jan 29, 2023
Merged

Check distribution and validate role variables #236

merged 3 commits into from
Jan 29, 2023

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Jan 29, 2023 •
edited
Loading

Proposed changes

  • Validate that various role variables have been set to one of the allowed values.
  • Refactor the distribution check yet again and check if your distribution's architecture is supported.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main.yml, README.md and CHANGELOG.md)

@alessfg
Check distribution and validate role variables
d2369a2 
* Validate that various role variables have been set to one of the allowed values.
* Refactor the distribution check yet again and check if your distribution's architecture is supported.
@alessfg alessfg requested a review from aknot242 as a code owner January 29, 2023 16:34
@alessfg alessfg self-assigned this Jan 29, 2023
@alessfg alessfg added the feature New feature or request label Jan 29, 2023
@alessfg alessfg added this to the 0.8.2 milestone Jan 29, 2023
@alessfg alessfg merged commit 016fbe9 into main Jan 29, 2023
@alessfg alessfg deleted the validate branch January 29, 2023 18:06
@alessfg alessfg removed the request for review from aknot242 January 29, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alessfg alessfg

Labels
feature New feature or request
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@alessfg