Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use amd64 platform for Molecule tests #231

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Use amd64 platform for Molecule tests #231

merged 1 commit into from
Jan 14, 2023

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Jan 14, 2023

Proposed changes

Explicitly specify amd64 as the platform used in Molecule tests. This will ensure that tests work as expected when run on different host architectures (e.g. newer Macbooks with arm processors).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main.yml, README.md and CHANGELOG.md)

@alessfg alessfg requested a review from aknot242 as a code owner January 14, 2023 22:18
@alessfg alessfg self-assigned this Jan 14, 2023
@alessfg alessfg added the tests Improvements to tests label Jan 14, 2023
@alessfg alessfg added this to the 0.8.2 milestone Jan 14, 2023
@alessfg alessfg removed the request for review from aknot242 January 14, 2023 23:17
@alessfg alessfg merged commit 5952779 into main Jan 14, 2023
@alessfg alessfg deleted the molecule-amd64 branch January 14, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Improvements to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant