Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TimeoutStartSec parameter #182

Merged
merged 3 commits into from
Apr 5, 2022
Merged

Add TimeoutStartSec parameter #182

merged 3 commits into from
Apr 5, 2022

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Apr 5, 2022

Proposed changes

The nginx_app_protect_timeout setting previous only applied to service stop operations. This parameter has been changed to nginx_app_protect_timeoutstopsec to better reflect its usage, and a new parameter, nginx_app_protect_timeoutstartsec has been introduced to tweak service start operation timeouts.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main.yml, README.md and CHANGELOG.md)

Unverified

This user has not yet uploaded their public signing key.
And change `nginx_app_protect_timeout` to `nginx_app_protect_timeoutstopsec`
@alessfg alessfg self-assigned this Apr 5, 2022
@alessfg alessfg added the breaking change Implies a breaking change label Apr 5, 2022
@alessfg alessfg added this to the 0.8.0 milestone Apr 5, 2022
@alessfg alessfg requested a review from aknot242 April 5, 2022 11:51
@github-actions github-actions bot added the enhancement Enhance/improve an existing feature label Apr 5, 2022
alessfg added 2 commits April 5, 2022 13:51

Unverified

This user has not yet uploaded their public signing key.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@alessfg alessfg merged commit 02c0ab6 into main Apr 5, 2022
@alessfg alessfg deleted the systemd-timeoutstartsec branch April 5, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Implies a breaking change enhancement Enhance/improve an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants