Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always update NAP dependencies to the latest available version #133

Merged
merged 7 commits into from
Oct 7, 2021

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Oct 6, 2021

Proposed changes

ENHANCEMENTS:

Move non NGINX App Protect specific dependencies from the role into the Molecule Dockerfile.

BUG FIXES:

Always update NGINX App Protect dependencies to the latest available version to avoid outdated dependency issues (e.g. outdated CA certificates).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Oct 6, 2021
@alessfg alessfg added bug Something isn't working enhancement Enhance/improve an existing feature labels Oct 6, 2021
@alessfg alessfg added this to the 0.6.2 milestone Oct 6, 2021
@alessfg alessfg requested a review from aknot242 October 7, 2021 21:33
@alessfg
Copy link
Collaborator Author

alessfg commented Oct 7, 2021

Resolves #36(?)

@aknot242
Copy link
Collaborator

aknot242 commented Oct 7, 2021

Does the introduction of the rhsm module set us up to be able to address this request at some point? #36

@alessfg
Copy link
Collaborator Author

alessfg commented Oct 7, 2021

I think it resolves that issue 😄

@alessfg alessfg merged commit 0bc4c54 into main Oct 7, 2021
@alessfg alessfg deleted the update-dependencies branch October 7, 2021 22:20
@alessfg alessfg mentioned this pull request Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Enhance/improve an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants