Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix license removal step #122

Merged
merged 3 commits into from
Aug 27, 2021
Merged

Fix license removal step #122

merged 3 commits into from
Aug 27, 2021

Conversation

aknot242
Copy link
Collaborator

@aknot242 aknot242 commented Aug 25, 2021 •
edited by alessfg
Loading

Proposed changes

The license and repo removal step was failing due to a bug introduced in the role refactoring when adding NAP DoS.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main.yml, README.md and CHANGELOG.md)

@aknot242 aknot242 added the bug Something isn't working label Aug 25, 2021
@aknot242 aknot242 requested a review from alessfg August 25, 2021 15:27
@aknot242 aknot242 self-assigned this Aug 25, 2021
@alessfg alessfg added this to the 0.6.1 milestone Aug 25, 2021
@aknot242 aknot242 merged commit 45029d9 into main Aug 27, 2021
@aknot242 aknot242 deleted the fix-license-removal branch August 27, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessfg alessfg alessfg approved these changes

Assignees

@aknot242 aknot242

Labels
bug Something isn't working
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@aknot242 @alessfg