Skip to content

Commit

Permalink
Fix license removal bug and prepare 0.3.1 release (#32)
Browse files Browse the repository at this point in the history
  • Loading branch information
alessfg authored Sep 22, 2020
1 parent 3e5fad6 commit 7837cfc
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
13 changes: 11 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# Changelog

## 0.3.1 (Unreleased)
## 0.3.1 (September 22, 2020)

FEATURES:

* Two new variables have been introduced:
* `nginx_app_protect_service_modify` -- Setting this variable to true/false will determine whether the default service timeout value gets modified.
* `nginx_app_protect_log_policy_target` -- This variable is intended as an eventual replacement for `nginx_app_protect_log_policy_syslog_target` and allows using different destinations for NGINX App Protect's log files.

ENHANCEMENTS:

Expand All @@ -9,7 +15,6 @@ ENHANCEMENTS:
BUG FIXES:

* Rename handlers to use more specific role related naming and prevent namespace collision issues.
* Add a `nginx_app_protect_service_modify` variable to revert a breaking change introduced in 0.3.0 where timeouts would not be set by default.
* Set NGINX handler to `state: restarted` to prevent some compatibility issues when NGINX App Protect is installed on an instance already running NGINX beforehand.
* Using `update_cache: true` by itself in the `apt` module is not always idempotent. Moved the NGINX App Protect installation task to a corresponding `apt` or `yum` module to avoid this scenario.

Expand All @@ -19,6 +24,10 @@ DEPRECATION WARNING:

* The ability to create an NGINX config including some basic App Protect directives has migrated to the NGINX config role available [here](https://github.com/nginxinc/ansible-role-nginx-config). Any new issues or PRs related to configuring NGINX App Protect directives should be submitted in the new NGINX Config repository. New issues or PRs related to configuring NGINX App Protect directives submitted in this repository will not be worked on. The NGINX App Protect directives configuration functionalities included in this role will be removed in an upcoming release.

BREAKING CHANGES:

* `nginx_app_protect_delete_license` has been renamed to `nginx_app_protect_remove_license`.

FEATURES:

* A new variable has been introduced:
Expand Down
2 changes: 1 addition & 1 deletion tasks/install/remove-license.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
nginx_app_protect_license_status: absent

- name: Delete repository data
include_tasks: "{{ role_path }}/tasks/install/setup-{{ ansible_facts['os_family'] | lower }}.yml"
include_tasks: "{{ role_path }}/tasks/install/install-{{ ansible_facts['os_family'] | lower }}.yml"

- name: Delete NGINX App Protect license
file:
Expand Down

0 comments on commit 7837cfc

Please sign in to comment.