Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip dependency review run on merge queue #378

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

lucacome
Copy link
Member

Proposed changes

The actions/dependency-review-action only works on PRs and we want to enforce the check. There's no option to enforce a check only on PR and not on Merge Queue. This makes the run in the Merge Queue pass.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome lucacome requested a review from a team as a code owner September 16, 2024 22:13
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 16, 2024
@lucacome lucacome force-pushed the chore/dependency-review branch from ee8af9a to 5b41ce6 Compare September 16, 2024 22:14
@lucacome lucacome enabled auto-merge September 16, 2024 22:14
@lucacome lucacome added this pull request to the merge queue Sep 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
@lucacome lucacome added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 39ec20f Sep 16, 2024
13 checks passed
@lucacome lucacome deleted the chore/dependency-review branch September 16, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants