Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yamllint to pre-commit config #309

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Add yamllint to pre-commit config #309

merged 3 commits into from
Jul 10, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jul 3, 2024

Proposed changes

Adds missing yamllint from pre-commit config

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome lucacome self-assigned this Jul 3, 2024
@lucacome lucacome requested a review from a team as a code owner July 3, 2024 21:17
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 3, 2024
@lucacome lucacome force-pushed the chore/yamllint-pre-commit branch from dadf250 to ef93e9d Compare July 3, 2024 21:20
@lucacome lucacome added this to the v1.2.2 milestone Jul 10, 2024
@lucacome lucacome enabled auto-merge (squash) July 10, 2024 21:02
@lucacome lucacome merged commit d4b83da into main Jul 10, 2024
12 checks passed
@lucacome lucacome deleted the chore/yamllint-pre-commit branch July 10, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
v1.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacome @sjberman