Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small typo in test name #2981

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix small typo in test name #2981

merged 1 commit into from
Jan 6, 2025

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Jan 6, 2025

Fix grammar in test case name.

@bjee19 bjee19 requested a review from a team as a code owner January 6, 2025 19:36
@github-actions github-actions bot added the bug Something isn't working label Jan 6, 2025
@sjberman
Copy link
Contributor

sjberman commented Jan 6, 2025

In the future, I'd prefix the branch name with tests or chore. Otherwise the PR gets tagged with the bug label and this will show up in the release notes as a bug. No need to re-create the PR, for now we can just remove the label when merging.

@bjee19 bjee19 added chore Pull requests for routine tasks and removed bug Something isn't working labels Jan 6, 2025
@bjee19 bjee19 merged commit 774a7c2 into nginx:main Jan 6, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-osborn kate-osborn kate-osborn approved these changes

@sjberman sjberman sjberman approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjee19 @sjberman @kate-osborn