Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NFR upgrade tests with NGINX Plus #2967

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Fix NFR upgrade tests with NGINX Plus #2967

merged 5 commits into from
Jan 3, 2025

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented Jan 2, 2025

Problem: When first deploying NGF edge version in the upgrade tests, NGINX Plus was not properly enabled. Also, once deployed, the upgraded version did not use the proper usage endpoint.

Solution: Ensure that the upgrade tests deploy the edge version of the NGINX Plus image, and set the proper usage endpoint once upgraded.

Testing: Upgrade tests run with Plus and now pass without errors.

Closes #2966

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman sjberman requested a review from a team as a code owner January 2, 2025 20:17
@github-actions github-actions bot added the tests Pull requests that update tests label Jan 2, 2025
kate-osborn
kate-osborn previously approved these changes Jan 2, 2025
@sjberman
Copy link
Contributor Author

sjberman commented Jan 2, 2025

Wait, I messed part of this up. This will deploy edge and upgrade, not the last release.

@kate-osborn kate-osborn dismissed their stale review January 2, 2025 20:22

un-approving

Problem: When first deploying NGF edge version in the upgrade tests, NGINX Plus was not properly enabled. Also, once deployed, the upgraded version did not use the proper usage endpoint.

Solution: Ensure that the upgrade tests deploy the edge version of the NGINX Plus image, and set the proper usage endpoint once upgraded.
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (8ac863e) to head (69f0ab2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2967   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files         111      111           
  Lines       11423    11423           
  Branches       50       50           
=======================================
  Hits        10273    10273           
  Misses       1089     1089           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman enabled auto-merge (squash) January 3, 2025 20:45
@sjberman sjberman merged commit 7d4e20c into main Jan 3, 2025
39 of 40 checks passed
@sjberman sjberman deleted the tests/fix-plus branch January 3, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

NFR upgrade test fails with NGINX Plus
3 participants