-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit empty deployment context fields #2903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: If an optional deployment context field wasn't set, an empty value would still be sent and cause the reporting server to return a 400. Solution: Use pointers on the optional fields to omit them from the context if they're empty.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2903 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 109 109
Lines 11150 11150
Branches 50 50
=======================================
Hits 10007 10007
Misses 1083 1083
Partials 60 60 ☔ View full report in Codecov by Sentry. |
bjee19
approved these changes
Dec 13, 2024
kate-osborn
approved these changes
Dec 13, 2024
sjberman
added a commit
that referenced
this pull request
Dec 13, 2024
Problem: If an optional deployment context field wasn't set, an empty value would still be sent and cause the reporting server to return a 400. Solution: Use pointers on the optional fields to omit them from the context if they're empty.
sjberman
added a commit
that referenced
this pull request
Dec 13, 2024
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: If an optional deployment context field wasn't set, an empty value would still be sent and cause the reporting server to return a 400. Solution: Use pointers on the optional fields to omit them from the context if they're empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: If an optional deployment context field wasn't set, an empty value would still be sent and cause the reporting server to return a 400.
Solution: Use pointers on the optional fields to omit them from the context if they're empty.
Testing: Verified that empty fields in the context still result in a successful report.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.