Watch UpstreamSettingsPolicies and translate into dataplane configuration #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
kate-osborn
commented
Dec 11, 2024
sjberman
reviewed
Dec 11, 2024
internal/mode/static/nginx/config/policies/upstreamsettings/validator.go
Outdated
Show resolved
Hide resolved
sjberman
approved these changes
Dec 11, 2024
bjee19
approved these changes
Dec 11, 2024
internal/mode/static/nginx/config/policies/upstreamsettings/validator.go
Outdated
Show resolved
Hide resolved
kate-osborn
force-pushed
the
feat/usp-graph
branch
from
ce451fd to
3b2c6ac
Compare
…he service belongs to the winning gateway
|
@bjee19 @sjberman re-requested reviews because I pushed a new commit: 3ed9e17 During manual testing yesterday, I found a bug where we were not writing status to the upstream settings policy when the Gateway was invalid. This is because we only added services to the ReferencedServices map if they were attached to at least one parent ref. This behavior also caused misleading status on routes that were attached to invalid Gateways when the Services they reference were processed after the route itself. The route would have |
sjberman
approved these changes
Dec 13, 2024
bjee19
approved these changes
Dec 13, 2024
kate-osborn
merged commit b968639
into
nginx:feature/upstream-settings-policy
44 checks passed
kate-osborn
added a commit
to kate-osborn/nginx-gateway-fabric
that referenced
this pull request
Dec 20, 2024
…tion (nginx#2887) Problem: As a userI want NGF to take my configuration for an UpstreamSettingsPolicy and transform it into data plane configuration within NGF, so that NGF can then translate those settings into NGINX configuration, and so that NGF maintains an abstraction layer between data plane configuration and the specific data plane NGF uses. Solution: Add controller to watch UpstreamSettingsPolicies, and store them in the cluster state as generic NGF Policies. Update the graph to validate and process these policies and attach them to the relevant Services. When building the dataplane configuration, store the policies on the relevant http upstreams.
kate-osborn
added a commit
that referenced
this pull request
Dec 20, 2024
…tion (#2887) Problem: As a userI want NGF to take my configuration for an UpstreamSettingsPolicy and transform it into data plane configuration within NGF, so that NGF can then translate those settings into NGINX configuration, and so that NGF maintains an abstraction layer between data plane configuration and the specific data plane NGF uses. Solution: Add controller to watch UpstreamSettingsPolicies, and store them in the cluster state as generic NGF Policies. Update the graph to validate and process these policies and attach them to the relevant Services. When building the dataplane configuration, store the policies on the relevant http upstreams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: As a user
I want NGF to take my configuration for an UpstreamSettingsPolicy and transform it into data plane configuration within NGF
So that NGF can then translate those settings into NGINX configuration
And so that NGF maintains an abstraction layer between data plane configuration and the specific data plane NGF uses.
Solution: Add controller to watch UpstreamSettingsPolicies, and store them in the cluster state as generic NGF Policies. Update the graph to validate and process these policies and attach them to the relevant Services. When building the dataplane configuration, store the policies on the relevant http upstreams.
Testing:
Closes #2810 #2812
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.