Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use staging endpoint for n+ reporting in pipeline #2885

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Problem: Pipeline uses production endpoint for N+ usage reporting, which should be reserved for production deployments.

Solution: Use staging endpoint in the pipeline. Devs will need to export the staging endpoint in their environments in order to run the nfr, functional, and conformance tests locally.

Testing: testing in pipeline

Closes #2881

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation tests Pull requests that update tests labels Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (16302f3) to head (4e5a889).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2885   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files         107      107           
  Lines       10997    10997           
  Branches       50       50           
=======================================
  Hits         9883     9883           
  Misses       1054     1054           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kate-osborn kate-osborn force-pushed the fix/use-staging-nplus-endpoint-in-pipeline branch from 5048d17 to acb0eda Compare December 10, 2024 20:25
@kate-osborn kate-osborn marked this pull request as ready for review December 10, 2024 20:50
@kate-osborn kate-osborn requested review from a team as code owners December 10, 2024 20:50
@kate-osborn kate-osborn force-pushed the fix/use-staging-nplus-endpoint-in-pipeline branch from acb0eda to 4e5a889 Compare December 10, 2024 21:36
@kate-osborn kate-osborn merged commit 58801be into main Dec 11, 2024
40 checks passed
@kate-osborn kate-osborn deleted the fix/use-staging-nplus-endpoint-in-pipeline branch December 11, 2024 16:30
kate-osborn added a commit to kate-osborn/nginx-gateway-fabric that referenced this pull request Dec 13, 2024
Problem: Pipeline uses production endpoint for N+ usage reporting,
which should be reserved for production deployments.

Solution: Use staging endpoint in the pipeline. Devs will need to
export the staging endpoint in their environments in order to run
the NFR, functional, and conformance tests locally.
kate-osborn added a commit that referenced this pull request Dec 13, 2024
Problem: Pipeline uses production endpoint for N+ usage reporting,
which should be reserved for production deployments.

Solution: Use staging endpoint in the pipeline. Devs will need to
export the staging endpoint in their environments in order to run
the NFR, functional, and conformance tests locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update N+ reporting endpoint in tests
3 participants