-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use staging endpoint for n+ reporting in pipeline #2885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Something isn't working
documentation
Improvements or additions to documentation
tests
Pull requests that update tests
labels
Dec 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2885 +/- ##
=======================================
Coverage 89.86% 89.86%
=======================================
Files 107 107
Lines 10997 10997
Branches 50 50
=======================================
Hits 9883 9883
Misses 1054 1054
Partials 60 60 ☔ View full report in Codecov by Sentry. |
kate-osborn
force-pushed
the
fix/use-staging-nplus-endpoint-in-pipeline
branch
from
December 10, 2024 20:25
5048d17
to
acb0eda
Compare
sjberman
approved these changes
Dec 10, 2024
bjee19
approved these changes
Dec 10, 2024
kate-osborn
force-pushed
the
fix/use-staging-nplus-endpoint-in-pipeline
branch
from
December 10, 2024 21:36
acb0eda
to
4e5a889
Compare
kate-osborn
added a commit
to kate-osborn/nginx-gateway-fabric
that referenced
this pull request
Dec 13, 2024
Problem: Pipeline uses production endpoint for N+ usage reporting, which should be reserved for production deployments. Solution: Use staging endpoint in the pipeline. Devs will need to export the staging endpoint in their environments in order to run the NFR, functional, and conformance tests locally.
This was referenced Dec 13, 2024
kate-osborn
added a commit
that referenced
this pull request
Dec 13, 2024
Problem: Pipeline uses production endpoint for N+ usage reporting, which should be reserved for production deployments. Solution: Use staging endpoint in the pipeline. Devs will need to export the staging endpoint in their environments in order to run the NFR, functional, and conformance tests locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
tests
Pull requests that update tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: Pipeline uses production endpoint for N+ usage reporting, which should be reserved for production deployments.
Solution: Use staging endpoint in the pipeline. Devs will need to export the staging endpoint in their environments in order to run the nfr, functional, and conformance tests locally.
Testing: testing in pipeline
Closes #2881
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.