-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce log verbosity #2455
Reduce log verbosity #2455
Conversation
Problem: NGF control plane logs are very verbose and give more information than is needed at the Info level. Solution: Reduce many logs to the debug level, including logs from the controller-runtime library. Tests will log at the debug level.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2455 +/- ##
==========================================
- Coverage 88.84% 88.79% -0.05%
==========================================
Files 100 100
Lines 7527 7531 +4
Branches 50 50
==========================================
Hits 6687 6687
- Misses 784 788 +4
Partials 56 56 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these code coverage checks fine to skip?
@bjee19 Yeah, we aren't testing logs. |
Problem: NGF control plane logs are very verbose and give more information than is needed at the Info level.
Solution: Reduce many logs to the debug level, including logs from the controller-runtime library. Tests will log at the debug level.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.