-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional tests for IPv6 Support #2238
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2238 +/- ##
=======================================
Coverage 87.76% 87.76%
=======================================
Files 96 96
Lines 6793 6793
Branches 50 50
=======================================
Hits 5962 5962
Misses 774 774
Partials 57 57 ☔ View full report in Codecov by Sentry. |
5696041
to
a4ed02d
Compare
@salonichf5 let's mark this as a draft since it includes commits from your other open PR. |
config/cluster/kind-cluster.yaml
Outdated
nodes: | ||
- role: control-plane | ||
networking: | ||
ipFamily: dual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you actually get dual IP in the pipeline? AFAIK GitHub doesn't support ipv6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the seems like that it is failing due to cluster not supporting Dual IP. Thinking on how to approach this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actions/runner-images#668 (comment)
Maybe a way to get it working? Should look into it closely...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am updating the kind create
step with the current config for dual
IP and adding the steps mentioned above !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 out of the 3 tests pass for IPFamily in kind cluster. Unable to figure out why the 3rd is failing.
I am unable to reproduce the issue locally but have asked @lucacome for some help
Passing tests
- Service with IPv4 and IPv6 configured, when NGF is enabled on dual stack
- Service with IPv4 configured, Service with IPv6 errors on the HTTPRoute , when NGF is enabled on IPv4 stack
Failing Tests
- Service with IPv6 configured, Service with IPv4 errors on the HTTPRoute, when NGF is enabled on IPv6 stack ( traffic passes successfully through the IPv6 service)
a4ed02d
to
d302f02
Compare
d302f02
to
c67b2e2
Compare
c67b2e2
to
3f21441
Compare
461cc25
to
b845e88
Compare
6bfa3d5
to
04e4f4f
Compare
0cf1671
to
843328e
Compare
843328e
to
6ec7f0d
Compare
Closing this PR because we need a |
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Users need a way to verify if IPv6/IPv4 works as expected.
Solution: Added functional tests for IPv6/IPv4 configuration.
Testing: Ran
make tests
under/tests/
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #2087
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.