-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sock files on nginx startup #2131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test needs to be updated to remove the Skip(): #1108 (comment) |
ciarams87
force-pushed
the
bug/rm-existing-sock-files
branch
from
June 17, 2024 15:03
1486905
to
7812722
Compare
pleshakov
reviewed
Jun 17, 2024
github-actions
bot
added
documentation
Improvements or additions to documentation
helm-chart
Relates to helm chart
labels
Jun 18, 2024
ciarams87
force-pushed
the
bug/rm-existing-sock-files
branch
2 times, most recently
from
June 20, 2024 14:12
7f507af
to
70c70e9
Compare
sjberman
reviewed
Jun 20, 2024
ciarams87
force-pushed
the
bug/rm-existing-sock-files
branch
from
June 20, 2024 16:02
24bb077
to
ecc4d6d
Compare
kate-osborn
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the tests are passing. Not sure what's causing the intermittent failure
ciarams87
force-pushed
the
bug/rm-existing-sock-files
branch
from
June 21, 2024 10:24
5e19fd3
to
66a0fc2
Compare
6 tasks
sjberman
approved these changes
Jun 24, 2024
pleshakov
approved these changes
Jun 24, 2024
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: NGF Pod cannot recover if NGINX master process fails without cleaning up Solution: Update the nginx Dockerfile CMD to clean up sock files on start-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
helm-chart
Relates to helm chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: NGF Pod cannot recover if NGINX master process fails without cleaning up
Solution: Update the nginx Dockerfile CMD to clean up sock files on start-up
Testing: Followed the repro steps in the bug and confirmed that the pod successfully recovers after killing the NGINX master process
Closes #1108
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.