Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run functional tests with LoadBalancer #2075

Merged
merged 11 commits into from
Jun 10, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented May 31, 2024

Proposed changes

Problem: Most users will install NGF with a Service type LoadBalancer, but we run our tests with NodePort

Solution: Switch to using LoadBalancer in the pipeline

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@github-actions github-actions bot added the chore Pull requests for routine tasks label May 31, 2024
@lucacome lucacome marked this pull request as ready for review June 3, 2024 22:26
@lucacome lucacome requested a review from a team as a code owner June 3, 2024 22:26
@lucacome lucacome self-assigned this Jun 4, 2024
Copy link
Contributor

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacome lucacome requested a review from a team June 6, 2024 15:30
@lucacome lucacome requested a review from a team June 7, 2024 17:35
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (051238f) to head (8fb3456).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2075      +/-   ##
==========================================
+ Coverage   87.61%   95.00%   +7.38%     
==========================================
  Files          96        1      -95     
  Lines        6694      220    -6474     
  Branches       50       50              
==========================================
- Hits         5865      209    -5656     
+ Misses        773       11     -762     
+ Partials       56        0      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome merged commit 07657cc into nginx:main Jun 10, 2024
41 checks passed
@lucacome lucacome deleted the chore/functional-tests branch June 10, 2024 15:24
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants