Add functional tests for ClientSettingsPolicies #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-osborn
force-pushed
the
tests/client-settings
branch
from
1c222f1 to
663dfc1
Compare
kate-osborn
changed the title
sjberman
reviewed
May 23, 2024
kate-osborn
force-pushed
the
tests/client-settings
branch
from
d28e1db to
519b736
Compare
pleshakov
reviewed
May 23, 2024
github-actions
bot
added
the
documentation
pleshakov
approved these changes
May 28, 2024
ciarams87
approved these changes
May 28, 2024
sjberman
reviewed
May 28, 2024
kate-osborn
force-pushed
the
tests/client-settings
branch
from
ec85a47 to
4f9956f
Compare
sjberman
approved these changes
May 28, 2024
lucacome
reviewed
May 28, 2024
kate-osborn
force-pushed
the
tests/client-settings
branch
2 times, most recently
from
bf09b75 to
23a8513
Compare
kate-osborn
force-pushed
the
tests/client-settings
branch
from
23a8513 to
d8c2a9b
Compare
lucacome
approved these changes
May 28, 2024
kate-osborn
force-pushed
the
tests/client-settings
branch
from
d8c2a9b to
588f3d2
Compare
kate-osborn
force-pushed
the
tests/client-settings
branch
from
9c1c6fb to
2a40745
Compare
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: No automated functional tests for ClientSettingsPolicies. Solution: Add functional tests for ClientSettingsPolicies. Test Cases: - NGF writes the correct status on policies - Valid policies are accepted - Conflicting policies are marked as conflicted - Invalid policies are not accepted - NGF propagates the body.maxSize setting in the NGINX config. This is the only field in ClientSettingsPolicy that we can test e2e by sending traffic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: No automated functional tests for ClientSettingsPolicies.
Solution: Add functional tests for ClientSettingsPolicies.
Test Cases:
body.maxSizesetting in the NGINX config. This is the only field in ClientSettingsPolicy that we can test e2e by sending traffic.Closes #1762
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.