Add Gateway API CRDs to the repo with kustomize #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
lucacome
force-pushed
the
chore/kustomize-gw-api
branch
from
943102d to
3218b61
Compare
pleshakov
reviewed
May 24, 2024
site/content/includes/installation/uninstall-gateway-api-resources.md
Outdated
Show resolved
Hide resolved
lucacome
force-pushed
the
chore/kustomize-gw-api
branch
from
ff356a4 to
1e14589
Compare
kate-osborn
approved these changes
May 28, 2024
pleshakov
approved these changes
May 28, 2024
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: We don't have a way to tie a version of the Gateway API to our release (or edge). There's also not a single source of truth for the API version. Solution: Use kustomize to add a specific version of the CRDs to our codebase. This way we only have to manage the version in one place and we can tie it to our releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: We don't have a way to tie a version of the Gateway API to our release (or edge). There's also not a single source of truth for the API version.
Solution: Use
kustomizeto add a specific version of the CRDs to our codebase. This way we only have to manage the version in one place and we can tie it to our releases.Please focus on (optional): Deploying standard and experimental versions of the API or
mainfor our tests.Continuation of #1803
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.